Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3 - with full go module support #140

Merged

Conversation

dnephin
Copy link
Member

@dnephin dnephin commented Feb 13, 2019

To properly support go modules we need a new import path. Following https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher the correct way to do that seems to be to release a new major version.

According to those docs this will be supported by the latest patch release of go1.9 and go1.10 as well.

Closes #156

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #140 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   83.16%   83.16%           
=======================================
  Files          29       29           
  Lines        2038     2038           
=======================================
  Hits         1695     1695           
  Misses        236      236           
  Partials      107      107
Impacted Files Coverage Δ
fs/ops.go 72.03% <ø> (ø) ⬆️
env/env.go 89.65% <ø> (ø) ⬆️
fs/manifest.go 86.66% <ø> (ø) ⬆️
golden/golden.go 90.16% <ø> (ø) ⬆️
fs/report.go 84.17% <ø> (ø) ⬆️
fs/path.go 86.9% <ø> (ø) ⬆️
assert/cmp/compare.go 88.77% <ø> (ø) ⬆️
internal/format/diff.go 88.88% <ø> (ø) ⬆️
assert/cmp/result.go 71.42% <ø> (ø) ⬆️
icmd/command.go 85.29% <ø> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04b215e...172219a. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #140 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage    82.8%   82.72%   -0.09%     
==========================================
  Files          29       29              
  Lines        2030     2020      -10     
==========================================
- Hits         1681     1671      -10     
  Misses        242      242              
  Partials      107      107
Impacted Files Coverage Δ
env/env.go 89.65% <ø> (ø) ⬆️
internal/format/diff.go 88.88% <ø> (ø) ⬆️
golden/golden.go 86.66% <ø> (-2.43%) ⬇️
icmd/command.go 85.18% <ø> (ø) ⬆️
assert/cmp/compare.go 88.88% <ø> (ø) ⬆️
fs/ops.go 66.1% <ø> (ø) ⬆️
fs/manifest.go 86.66% <ø> (ø) ⬆️
assert/result.go 72.91% <ø> (ø) ⬆️
fs/report.go 84.17% <ø> (ø) ⬆️
fs/path.go 84.52% <ø> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9c679c...4c906a1. Read the comment docs.

@vdemeester
Copy link
Member

I would prefer "Major subdirectory:" solution as it provides the greatest backwards compatibility (to support ~1.8). That said, I feels it would be way more work for not too much… so, I think SGTM but I'm not sure I see all the implication (as, running dep ensure -update github.com/gotestyourself/gotest.tools, what will it do ?).

Any way, we're doing what the go docs says, and we gotta start somewhere so… LGTM :wink:

@dnephin dnephin mentioned this pull request Jun 20, 2019
@dnephin dnephin force-pushed the release-v3-with-go-mod-support branch from 4c906a1 to 57bf5cd Compare June 26, 2019 23:44
To properly support go modules we need a new import path. Following
https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher the
correct way to do that seems to be to release a new major version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go modules compatibility
2 participants