Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -mod=vendor and mount pkg/mod instead #136

Merged
merged 1 commit into from
Mar 2, 2019

Conversation

jmattheis
Copy link
Member

Makefile Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 2, 2019

Codecov Report

Merging #136 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #136   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          39     39           
  Lines        1415   1415           
=====================================
  Hits         1415   1415

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a59426...5dc3849. Read the comment docs.

See gotify/plugin-template#4
tl;dr: Using vendor makes plugins incompatible.
@jmattheis jmattheis merged commit 4814fe8 into master Mar 2, 2019
@jmattheis jmattheis deleted the fix-incompatible-plugins branch March 2, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants