Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cache @link{https://nodejs.org/api/modules.html#caching} #14

Open
wants to merge 1 commit into
base: default
Choose a base branch
from

Conversation

GrinZero
Copy link

Increasing result caching to reuse running results - but this may not be an excellent solution, and we still need more practice.

@goto-bus-stop
Copy link
Owner

Thanks for the PR! Since this is just caching the whole resolve() call, I think this is better solved in your application code. Caching might not be the right answer for all users. For example, what happens if I use resolve() in a long-running process, and the files on disk change? If the result is cached by the crate then you would not be able to react to changes until you restart the whole process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants