-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding EIPAssociation CRD and Controller to allow static EIP unassignment #16
Merged
alfredkrohmer
merged 13 commits into
goto-opensource:main
from
alabonte7:feature/eip-association-controller
Jul 4, 2023
Merged
Adding EIPAssociation CRD and Controller to allow static EIP unassignment #16
alfredkrohmer
merged 13 commits into
goto-opensource:main
from
alabonte7:feature/eip-association-controller
Jul 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfredkrohmer
requested changes
Apr 21, 2023
alfredkrohmer
approved these changes
May 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the last 2 nitpicks, other than that looks good 🙂
alfredkrohmer
requested changes
May 12, 2023
alfredkrohmer
approved these changes
May 12, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jul 4, 2023
## [1.1.0](v1.0.1...v1.1.0) (2023-07-04) ### Features * adding EIPAssociation CRD and controller to allow static EIP unassignment ([#16](#16)) ([4ffd565](4ffd565))
This was referenced Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like this operator to unassign an EIP from a pod whenever a new CRD EIPAssociation is destroyed.
This would allow pods not to have direct owner reference to the EIP which would allow having static EIP and pods being able to assign this EIP on scale-up and unassigning it on scale-down