Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istanbul hangs when using OSX Mavericks #133

Closed
cressie176 opened this issue Jan 5, 2014 · 11 comments
Closed

Istanbul hangs when using OSX Mavericks #133

cressie176 opened this issue Jan 5, 2014 · 11 comments

Comments

@cressie176
Copy link

I'm trying to get istanbul working with yadda but when I try running istanbul cover _mocha the process never returns. A coverage directory is created but it's empty.

I get the same problem if I create a simple test.js with nothing more than a console.log and do istanbul cover test.js

OSX Mavericks
Istanbul 0.2.3
Node v0.10.22

Any ideas?

@cressie176
Copy link
Author

The problem appears to be related to OSX (possibly Mavericks). If I mount the same project directory into an ubuntu vm (using vagrant) istanbul works

@gotwarlost
Copy link
Owner

Unfortunately I don't have access to a Mavericks instance - please update this issue with anything you might find.

@cressie176
Copy link
Author

It looks like istanbul is following symlinks (created via npm link). Yadda includes a set of examples, which uses npm link to make the yadda module available, e.g.

yadda
|- examples
   |- mocha-async
      |- node_modules
         |- yadda (sym link to top yadda directory)

I put a console.log in Glob.js and found the following...

examples/mocha-async/node_modules/yadda/examples/mocha-sync/node_modules/yadda/examples/zombie/node_modules/mocha/node_modules/jade/jade.js

I've tried excluding directories using -x istanbul cover -x examples -x dist _mocha but it didn't make any difference. Have I got the -x syntax correct?

@akinnee
Copy link

akinnee commented Feb 19, 2014

It hangs for me on Mavericks as well. I am using it as part of my test process in grunt. It generates some output, but the process never completes. https://www.dropbox.com/s/j83yyl1xsmonbov/Screenshot%202014-02-19%2012.49.57.png

@cressie176
Copy link
Author

Looks like the -x only excludes files after iterating through all the directories. Because my symlinks are recursive it doesn't help

@smurthas
Copy link

This appears to be due to a bug in Glob: isaacs/node-glob#86.

@popomore
Copy link
Contributor

Fix of Glob work for me, @gotwarlost can you upgrade to the lastest version?

@popomore
Copy link
Contributor

@mklabs

@mklabs
Copy link

mklabs commented Jun 13, 2015

thanks @popomore

Hello @gotwarlost Do you still support node 0.8 ? I'm working on node-fileset 0.2.x versions and will most likely drop support to 0.8

@davglass
Copy link
Collaborator

I don't think that we should support Node 0.8.x.

@mklabs
Copy link

mklabs commented Jun 13, 2015

Thanks @davglass I think so too. It really ease the process for me, node-glob also only supports iojs, 0.10 and 0.12: https://github.com/isaacs/node-glob/blob/master/.travis.yml

popomore added a commit to popomore/istanbul that referenced this issue Jun 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants