-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix circular dependency found by Node.JS 14 #940
base: master
Are you sure you want to change the base?
Conversation
Same error on Node v.15.5.0. thx for the PR, hoping it will get merged asap |
A simpler change is just to read the VERSION from Command defined in line 6:
👍 Can we get this change merged? |
@gotwarlost Hello from 2023. Can we please get this merged? |
Assuming this repo remains confusingly not archived, from npm's instanbul:
|
Looking for a fix on this issue. The Thanks, |
Istanbul version
0.4.5
seems to produce a circular dependency when using Node.JS 14The problem seems to be that VERSION is loaded before lib/commands/index.js is built and ready to be exported.
Requiring VERSION once it is needed, namely once the
help
command runs, solves the problem.Referring to issue hoprnet/hoprnet#1241.