docs: add typings to some examples #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used strongly-typed useState<Date>(...) hook
Used strongly-typed useState<Date>(...) hook
Used strongly-typed useState<Date>(...) hook
Used strongly-typed useState<Date>(...) hook
|
I think this PR is ready for review/merge now. |
gpbl
requested changes
Jul 7, 2024
gpbl
changed the title
Date can also be undefined Co-authored-by: Giampaolo Bellavite <[email protected]>
Date can also be undefined Co-authored-by: Giampaolo Bellavite <[email protected]>
Removed unneeded typing Co-authored-by: Giampaolo Bellavite <[email protected]>
Added Date array type Co-authored-by: Giampaolo Bellavite <[email protected]>
Removed unneeded/obvious typing Co-authored-by: Giampaolo Bellavite <[email protected]>
|
Thank you for reviewing! I commited your requested changes. |
gpbl
approved these changes
Jul 7, 2024
|
Thanks you, @dave-meyer ! |
Brooooooklyn
pushed a commit
to toeverything/AFFiNE
that referenced
this pull request
Sep 3, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-day-picker](https://daypicker.dev) ([source](https://redirect.github.com/gpbl/react-day-picker)) | [`^8.10.1` -> `^9.0.0`](https://renovatebot.com/diffs/npm/react-day-picker/8.10.1/9.0.8) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>gpbl/react-day-picker (react-day-picker)</summary> ### [`v9.0.8`](https://redirect.github.com/gpbl/react-day-picker/releases/tag/v9.0.8) [Compare Source](https://redirect.github.com/gpbl/react-day-picker/compare/v9.0.7...v9.0.8) This release fixes a regression in v9.0.7 affecting range mode. #### What's Changed - fix: update the displayed month only if start/end month change by [@​gpbl](https://redirect.github.com/gpbl) in [gpbl/react-day-picker#2358 **Full Changelog**: gpbl/react-day-picker@v9.0.7...v9.0.8 ### [`v9.0.7`](https://redirect.github.com/gpbl/react-day-picker/releases/tag/v9.0.7) [Compare Source](https://redirect.github.com/gpbl/react-day-picker/compare/v9.0.6...v9.0.7) This release improves compatibility with v8 and fix an issue with the calendar navigation. #### What's Changed - fix: update calendar state when `startMonth` or `endMonth` change by [@​gpbl](https://redirect.github.com/gpbl) in [gpbl/react-day-picker#2343 - feat: allow partial locales, export `defaultLocale` by [@​gpbl](https://redirect.github.com/gpbl) in [gpbl/react-day-picker#2348 - feat: allow `undefined` as initially selected value, as it was in v8 by [@​gpbl](https://redirect.github.com/gpbl) in [gpbl/react-day-picker#2341 - docs: changed class name `calendar` to `root` in the examples by [@​gpbl](https://redirect.github.com/gpbl) in [gpbl/react-day-picker#2347 - docs: replaced deprecated props by [@​josephmarkus](https://redirect.github.com/josephmarkus) in [gpbl/react-day-picker#2336 #### New Contributors - [@​josephmarkus](https://redirect.github.com/josephmarkus) made their first contribution in [gpbl/react-day-picker#2336 **Full Changelog**: gpbl/react-day-picker@v9.0.6...v9.0.7 ### [`v9.0.6`](https://redirect.github.com/gpbl/react-day-picker/releases/tag/v9.0.6) [Compare Source](https://redirect.github.com/gpbl/react-day-picker/compare/v9.0.5...v9.0.6) This release addresses the failed import of the common-js module for some app builder and add new `data-` attributes to help the integration with Tailwind. Thanks for your feedback! #### What's Changed - fix(build): add package.json to dist/cjs module by [@​gpbl](https://redirect.github.com/gpbl) in [gpbl/react-day-picker#2330 - feat: add new data-attributes to the day cells by [@​gpbl](https://redirect.github.com/gpbl) in [gpbl/react-day-picker#2331 #### New Contributors - [@​lesleh](https://redirect.github.com/lesleh) made their first contribution in [gpbl/react-day-picker#2329 **Full Changelog**: gpbl/react-day-picker@v9.0.5...v9.0.6 ### [`v9.0.5`](https://redirect.github.com/gpbl/react-day-picker/releases/tag/v9.0.5) [Compare Source](https://redirect.github.com/gpbl/react-day-picker/compare/v9.0.4...v9.0.5) This release improves the range mode behavior (see the [updated docs](https://daypicker.dev/docs/selection-modes#range-mode)) and address some styling issues. #### What's Changed - fix: improved range mode to work with min / required props by [@​gpbl](https://redirect.github.com/gpbl) in [gpbl/react-day-picker#2326 - fix(style): typo in css rdp-hidden module css breaking CSS builds by [@​ayuhito](https://redirect.github.com/ayuhito) in [gpbl/react-day-picker#2307 - fix(style): borders grid are not collapsed by [@​gpbl](https://redirect.github.com/gpbl) in [gpbl/react-day-picker#2323 - fix(style): week numbers are now centered by [@​gpbl](https://redirect.github.com/gpbl) in gpbl/react-day-picker@c919ad8 #### New Contributors - [@​ayuhito](https://redirect.github.com/ayuhito) made their first contribution in [gpbl/react-day-picker#2307 - [@​rishabh-ink](https://redirect.github.com/rishabh-ink) made their first contribution in [gpbl/react-day-picker#2311 **Full Changelog**: gpbl/react-day-picker@v9.0.4...v9.0.5 ### [`v9.0.4`](https://redirect.github.com/gpbl/react-day-picker/releases/tag/v9.0.4) [Compare Source](https://redirect.github.com/gpbl/react-day-picker/compare/v9.0.3...v9.0.4) This release fixes some bugs and improves compatibility with v8.10. Thanks for your feedback and patience! 🤖 #### What's Changed - fix(css): typo in `.rdp-range_end` by [@​AlessioDP](https://redirect.github.com/AlessioDP) in [gpbl/react-day-picker#2298 - fix(css): dropdown is transparent in Windows OS by [@​gpbl](https://redirect.github.com/gpbl) in [gpbl/react-day-picker#2300 - fix: `endMonth` date not working as expected by [@​gpbl](https://redirect.github.com/gpbl) in [gpbl/react-day-picker#2301 - feat: added back `onDayMouseEnter` and `onDayMouseLeave` by [@​gpbl](https://redirect.github.com/gpbl) in [gpbl/react-day-picker#2304 #### New Contributors - [@​AlessioDP](https://redirect.github.com/AlessioDP) made their first contribution in [gpbl/react-day-picker#2298 **Full Changelog**: gpbl/react-day-picker@v9.0.3...v9.0.4 ### [`v9.0.3`](https://redirect.github.com/gpbl/react-day-picker/releases/tag/v9.0.3) [Compare Source](https://redirect.github.com/gpbl/react-day-picker/compare/v9.0.2...v9.0.3) This release fixes two issues found with the grid style and the range mode. #### What's Changed - fix: alignment of grid elements by [@​gpbl](https://redirect.github.com/gpbl) in [gpbl/react-day-picker#2294 - fix: range mode not updating when selected prop changes by [@​gpbl](https://redirect.github.com/gpbl) in [gpbl/react-day-picker#2295 **Full Changelog**: gpbl/react-day-picker@v9.0.2...v9.0.3 ### [`v9.0.2`](https://redirect.github.com/gpbl/react-day-picker/releases/tag/v9.0.2) [Compare Source](https://redirect.github.com/gpbl/react-day-picker/compare/v9.0.1...v9.0.2) This update improves backward compatibility with v8.10.1 for range selection mode. #### What's Changed - feat: add `excludeDisabled` prop for range mode by [@​gpbl](https://redirect.github.com/gpbl) in [gpbl/react-day-picker#2290 **Full Changelog**: gpbl/react-day-picker@v9.0.1...v9.0.2 ### [`v9.0.1`](https://redirect.github.com/gpbl/react-day-picker/releases/tag/v9.0.1) [Compare Source](https://redirect.github.com/gpbl/react-day-picker/compare/v9.0.0...v9.0.1) This update improves backward compatibility with v8.10.1. #### What's Changed - fix: prop types not being correctly interpreted by TS by [@​gpbl](https://redirect.github.com/gpbl) in [gpbl/react-day-picker#2283 - feat: add `DeprecatedUI` enum by [@​gpbl](https://redirect.github.com/gpbl) in [gpbl/react-day-picker#2284 **Full Changelog**: gpbl/react-day-picker@v9.0.0...v9.0.1 ### [`v9.0.0`](https://redirect.github.com/gpbl/react-day-picker/releases/tag/v9.0.0) [Compare Source](https://redirect.github.com/gpbl/react-day-picker/compare/v8.10.1...v9.0.0) DayPicker v9 is a major release including significant updates related to accessibility, customization and localization. - See the updated docs at https://daypicker.dev and the [upgrading Guide](https://daypicker.dev/upgrading) for more details. ##### Install the Latest Version ```bash npm install react-day-picker@latest ``` #### What’s New - Moved `date-fns` from peer dependencies to dependencies. - Added support for [UTC dates](https://daypicker.dev/docs/localization#utc-dates) and [Jalali Calendar](https://daypicker.dev/docs/localization#jalali-calendar). - [Enhanced accessibility](https://daypicker.dev/docs/accessibility) to better comply with [WCAG 2.1](https://www.w3.org/TR/WCAG21/) recommendations. - [Simplified styles](https://daypicker.dev/docs/styling) and new CSS variables for easier customization. - Improved selection logic for [range mode](https://daypicker.dev/docs/selection-modes.mdx). - New `dropdown-years` and `dropdown-months` caption layouts. - New `hideWeekdayRow` and `hideNavigation` props. - Updated for a complete [custom components](https://daypicker.dev/guides/custom-components) support. - Improved typings and props for better compatibility in TypeScript `strict` mode. #### Breaking Changes While we tried to keep the API as stable as possible, some breaking changes were necessary to improve the library: - The updated ARIA labels could require new translations or updated unit tests selectors. - Custom CSS styles will likely break, due to the updated CSS classes and simplified styles. - Custom Components have new API and may break. - Some typings have been renamed or deprecated. - The `useInput` hook has been removed. See [Input fields](https://daypicker.dev/guides/input-fields) guide for more details. - `onWeekNumberClick` has been removed. Use a custom component to handle week number clicks. - The updated build system to ESM and CommonJS could break some custom bundler. ##### Upgrading Guide We prepared a [Upgrading guide](https://daypicker.dev/upgrading) for help upgrading your app to v9. We welcome [feedback](https://redirect.github.com/gpbl/react-day-picker/discussions) about the upgrade process, to ensure it's smooth for everyone. #### Compatibility DayPicker v9 is compatible with React 16.8+. #### Get Support and Report Issues Get support, report issues, and provide feedback on the [Discussion forums](https://redirect.github.com/gpbl/react-day-picker/discussions). Thanks. #### New Contributors - [@​grzegorzpokorski](https://redirect.github.com/grzegorzpokorski) made their first contribution in [gpbl/react-day-picker#2124 - [@​zaaakher](https://redirect.github.com/zaaakher) made their first contribution in [gpbl/react-day-picker#2137 - [@​ArthurGoupil](https://redirect.github.com/ArthurGoupil) made their first contribution in [gpbl/react-day-picker#2230 - [@​johnnysedh3lllo](https://redirect.github.com/johnnysedh3lllo) made their first contribution in [gpbl/react-day-picker#2252 - [@​xardit](https://redirect.github.com/xardit) made their first contribution in [gpbl/react-day-picker#2254 - [@​dave-meyer](https://redirect.github.com/dave-meyer) made their first contribution in [gpbl/react-day-picker#2231 - [@​benasher44](https://redirect.github.com/benasher44) made their first contribution in [gpbl/react-day-picker#2249 - [@​RyanCavanaugh](https://redirect.github.com/RyanCavanaugh) made their first contribution in [gpbl/react-day-picker#2275 - [@​kesoji](https://redirect.github.com/kesoji) made their first contribution in [gpbl/react-day-picker#2281 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/toeverything/AFFiNE). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM4LjU5LjIiLCJ0YXJnZXRCcmFuY2giOiJjYW5hcnkiLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous code examples on the website sometimes used untyped 'useState' hooks. This made it sometimes difficult to understand the code. My changes add strong typing (i.e.
useState<Date>()) to wherever the code was not self explanatory.Also, these changes unify the code examples, since some of them had strongly typed hooks and others did not.
Type of Change
Checklist
Before submitting your pull request, please make sure the following is done:
Linked Issues
None
Test Plan
Not needed
Screenshots (if appropriate)
Not needed
Further Comments
None