Support bidirectional text (ltr and rtl) [WIP] #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support bidirectional text in the UI (as opposed to content such as podcast names or descriptions), we need to figure out the currently used language in the template (see docs).
For some (currently still unknown reasons), this always returns
enwhen in the context of the template. In the view (eg wtihdjango.utils.translation.get_language) the correct language is returned.I have asked on Stack Overflow about this issue (https://stackoverflow.com/q/51641412/693140), but have not been able to figure it out.
Once this is fixed we can create a rtl-stylesheet that is conditional on the language.
See also