-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTS: Color space conversion operation test for CopyToTexture #1043
Conversation
This PR add cts to test copyExternalImageToTexture() color space conversion ability. It creates canvas with color space attr and copy to dst texture in user defined color space through CopyExternalImageToTexture(). Issue:gpuweb#913
The compatible Blink CL is here https://chromium-review.googlesource.com/c/chromium/src/+/3501779 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments - though I did not actually review the test content. I think Kai would be a better reviewer here.
@austinEng I try to upgrade tsc but got lots of errors. Maybe we should use a seperate PR to do the upgrading. |
I'm working on a tsc upgrade, should be able to get it done today. |
TypeScript update landed, please merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/ a few nits
Previews, as seen when this build job started (8702c63): |
One problem here: |
Do you know what causes this? If it's slowness in the implementation, we can mark the test as slow in our expectations (hopefully - though we should consider doing so before landing this PR so that the Chrome WebGPU Gardener won't have to debug it). |
Previews, as seen when this build job started (5a0b912): |
Yes, and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently I forgot to complete my re-review, sorry.
Since the other format works fine, I think this is the bottleneck.
OK. Since we know it's slow, do you think we could disable the f16 tests in this PR so we can land it, and re-enable them (hopefully with optimizations) in a separate PR?
The f16 expect logic will cover more than color_space conversion cases. So I try to fix it by comparing the f16bits and handling ~0 values. PTAL again, thanks! |
Previews, as seen when this build job started (7481681): |
After this fixing, f16 format cases could finished in ~4s on my local machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix for both the tolerance and the performance! and simpler too
This PR add cts to test copyExternalImageToTexture() color space
conversion ability.
It creates canvas with color space attr and copy to dst texture in
user defined color space through CopyExternalImageToTexture().
Issue: #913
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.