Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove copyToTexture,CopyExternalImageToTexture:destination_texture,d… #1864

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

Jiawei-Shao
Copy link
Collaborator

…imension:*

This patch removes the validation test on the dimension of the destination texture of CopyExternalImageToTexture() as now we only allow textures with RENDER_ATTACHMENT usage to be the destination texture used in that API, while in current SPEC only 2D textures are allowed to be created with RENDER_ATTACHMENT usage.

Issue: #913


Requirements for PR author:

  • [*] All missing test coverage is tracked with "TODO" or .unimplemented().
  • [*] New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • [* Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

…imension:*

This patch removes the validation test on the dimension of the destination
texture of CopyExternalImageToTexture() as now we only allow textures with
RENDER_ATTACHMENT usage to be the destination texture used in that API, while
in current SPEC only 2D textures are allowed to be created with RENDER_ATTACHMENT
usage.
@github-actions
Copy link

Previews, as seen when this build job started (c25a0f9):
Run tests | View tsdoc

Copy link
Contributor

@shaoboyan shaoboyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@Jiawei-Shao Jiawei-Shao merged commit 409e987 into main Sep 26, 2022
@Jiawei-Shao Jiawei-Shao deleted the remove-test branch September 26, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants