Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op: Implement 'default_blend_constant,setting_blend_constant' test in blending.spec.ts #1984

Merged
merged 1 commit into from
Nov 11, 2022
Merged

op: Implement 'default_blend_constant,setting_blend_constant' test in blending.spec.ts #1984

merged 1 commit into from
Nov 11, 2022

Conversation

Gyuyoung
Copy link
Collaborator

@Gyuyoung Gyuyoung commented Nov 10, 2022 •
edited by kainino0x
Loading

This PR implements a new test to ensure that setting the blending constant works correctly.

Issue: #1835

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@github-actions
Copy link

Previews, as seen when this build job started (0a5fb89):
Run tests | View tsdoc

@Gyuyoung Gyuyoung marked this pull request as ready for review November 10, 2022 08:22
kainino0x
kainino0x approved these changes Nov 11, 2022
View reviewed changes
src/webgpu/api/operation/rendering/blending.spec.ts Outdated Show resolved Hide resolved
src/webgpu/api/operation/rendering/blending.spec.ts Outdated Show resolved Hide resolved
@Gyuyoung
op: Implement 'simple_blend_constant,setting_blend_constant' test in …
4fbaf2f 
…blending.spec.ts

This PR implements a new test to ensure that setting the blending constant works
correctly.

Issue: gpuweb#1835
@github-actions
Copy link

Previews, as seen when this build job started (4fbaf2f):
Run tests | View tsdoc

@Gyuyoung Gyuyoung merged commit c6c3b72 into gpuweb:main Nov 11, 2022
@Gyuyoung Gyuyoung deleted the setting-blend-constant branch November 11, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kainino0x kainino0x kainino0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gyuyoung @kainino0x