-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op: Implement 'filter_mode,minFilter' test in filter_mode.spec.ts #2090
Draft
Gyuyoung
wants to merge
1
commit into
gpuweb:main
Choose a base branch
from
Gyuyoung:filter-mode-minFilter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I couldn't find a proper way to test the filter modes yet. I aimed to write a test that filter mode affected the expected colors in drawing the slanted plane. But, the filter modes(
mipmapFilter
first for now) didn't affect the expected result. Could you please give me any idea or comment on how to test thefooFilter
affects the expected color?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be useful to visualize the colorAttachment. Unfortunately we never managed to add good facilities for this - I think I started writing some but never finished.
When running in a browser, you can hack in code to visualize it, e.g. add a canvas to the
document.body
and change drawSlantedPlane to get its attachment from getCurrentTexture instead of createTexture. Example:Gyuyoung/cts@filter-mode-minFilter...kainino0x:cts:example-visualization
Here you can see there is a slight difference in the result (but it's subtle):
linear
nearest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for giving me more information. I don't find a way to test it yet. Let me take a look at this more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI #2072 (comment)