Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op: Add 'srcFactor' and 'dstFactor' to the parameters in 'blending,clamping' test #2107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Gyuyoung
Copy link
Collaborator

@Gyuyoung Gyuyoung commented Jan 4, 2023

This PR adds srcFactor and dstFactor to the parameters of 'blending,clamping' test in color_target_state.spec.ts.

Issue: #1835


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Previews, as seen when this build job started (418a795):
Run tests | View tsdoc

.filter(t => {
return (
!(
t.srcFactor === 'one-minus-src-alpha' ||
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I applied these factors that include 'alpha', the test failed. Do you know any clue why?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I run this PR without the filter then I hit an unreachable in calculateExpectedClampValue. But fixing that it still fails. At least some of the failures are because we expect the color and alpha channels to always be the same, but that's not always true: https://gpuweb.github.io/gpuweb/#enumdef-gpublendfactor

"src-alpha-saturated" (min(Asrc, 1 - Adst), min(Asrc, 1 - Adst), min(Asrc, 1 - Adst), 1)

Note the last channel has different factors.

The other issue I see is that when the format is rg16float, there is no alpha channel. Therefore dst-alpha won't have the initial value the code expects. I think missing channels default to ,0,0,1 so dst-alpha would be 1 (similar to this), but I'm not 100% sure about that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ,0,0,1. Was confirmed in gpuweb/gpuweb#2025

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other issue I see is that when the format is rg16float, there is no alpha channel. Therefore dst-alpha won't have the initial value the code expects. I think missing channels default to ,0,0,1 so dst-alpha would be 1 (similar to this), but I'm not 100% sure about that.

yes, as you thought, the failures come from rg16float format and src-alpha-saturated factor. It's likely this PR should make the test use RGBA instead of using one value.

@Gyuyoung Gyuyoung marked this pull request as ready for review January 4, 2023 13:02
…amping' test

This PR adds srcFactor and dstFactor to the parameters of 'blending,clamping' test
in color_target_state.spec.ts.

Issue: gpuweb#1835
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Previews, as seen when this build job started (dbaa9e3):
Run tests | View tsdoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants