Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fragment_input @builtin(sample_mask) #3404

Merged
merged 7 commits into from
Feb 15, 2024

Conversation

greggman
Copy link
Contributor

@greggman greggman commented Feb 14, 2024


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Copy link
Contributor

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice test, even I understand what's going on, I think.

Copy link
Contributor

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! that's great.

Copy link
Contributor

@shrekshao shrekshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with optional comment

@greggman greggman enabled auto-merge (squash) February 15, 2024 00:14
@greggman greggman merged commit b03d6d4 into gpuweb:main Feb 15, 2024
1 check passed
@greggman greggman deleted the test-sample-mask-input branch February 15, 2024 00:41
dneto0 added a commit to dneto0/cts that referenced this pull request Apr 11, 2024
The sample_mask fragment input is already tested, via PR gpuweb#3404
@dneto0 dneto0 mentioned this pull request Apr 11, 2024
8 tasks
dneto0 added a commit that referenced this pull request Apr 11, 2024
The sample_mask fragment input is already tested, via PR #3404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants