-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wgsl: Add short-circuiting validation tests #3567
Conversation
Test that the short-circuiting logical expressions are only accepted for scalar boolean types. Also test that they guard invalid expressions on the right-hand-side when the left-hand-side is a const-expression.
src/webgpu/shader/validation/expression/binary/short_circuiting_and_or.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
src/webgpu/shader/validation/expression/binary/short_circuiting_and_or.spec.ts
Outdated
Show resolved
Hide resolved
src/webgpu/shader/validation/expression/binary/short_circuiting_and_or.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also added override
tests.
src/webgpu/shader/validation/expression/binary/short_circuiting_and_or.spec.ts
Outdated
Show resolved
Hide resolved
src/webgpu/shader/validation/expression/binary/short_circuiting_and_or.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
gpuweb/gpuweb#4801 resolves the spec issue. |
Test that the short-circuiting logical expressions are only accepted for scalar boolean types.
Also test that they guard invalid expressions on the right-hand-side when the left-hand-side is a const-expression.
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.