Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: Add short-circuiting validation tests #3567

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Conversation

jrprice
Copy link
Contributor

@jrprice jrprice commented Mar 28, 2024

Test that the short-circuiting logical expressions are only accepted for scalar boolean types.

Also test that they guard invalid expressions on the right-hand-side when the left-hand-side is a const-expression.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Test that the short-circuiting logical expressions are only accepted
for scalar boolean types.

Also test that they guard invalid expressions on the right-hand-side
when the left-hand-side is a const-expression.
@jrprice jrprice added the wgsl label Mar 28, 2024
@jrprice jrprice requested a review from dneto0 March 28, 2024 13:53
Copy link
Contributor

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor Author

@jrprice jrprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added override tests.

Copy link
Contributor

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alan-baker
Copy link
Contributor

gpuweb/gpuweb#4801 resolves the spec issue.

@jrprice jrprice merged commit 2f55512 into gpuweb:main Sep 16, 2024
1 check passed
@jrprice jrprice deleted the expressions branch September 16, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants