Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch compat WGSL errors to pipeline errors #3894

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

greggman
Copy link
Contributor

@greggman greggman commented Aug 5, 2024

Issue: #3893


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@greggman greggman requested a review from jrprice August 5, 2024 22:52
Copy link
Contributor

@alan-baker alan-baker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest renaming render_pipeline/shader_module.spec.ts as the name doesn't seem appropriate anymore.

@greggman greggman force-pushed the move-wgsl-errors-to-pipeline branch from 4653c09 to 647ce00 Compare August 6, 2024 16:51
@greggman greggman enabled auto-merge (squash) August 6, 2024 17:12
@greggman
Copy link
Contributor Author

greggman commented Aug 6, 2024

renamed

@greggman greggman merged commit 28935e3 into gpuweb:main Aug 6, 2024
1 check passed
@greggman greggman deleted the move-wgsl-errors-to-pipeline branch August 6, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants