Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Origin Trial token for Subgroups in localhost:8080 #3939

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

dneto0
Copy link
Contributor

@dneto0 dneto0 commented Sep 6, 2024

Adds a localhost:8080 token to standalone/index.html for local testing.

https://crbug.com/358117283

Followup to #3895

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Adds a localhost:8080 token to standalone/index.html for local testing.

https://crbug.com/358117283

Followup to gpuweb#3895
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously we've served up the localhost tokens from dev_server.ts instead. Do you need this because you're running this through some other server on localhost?

If so, I think it's redundant to have it in both, so we could have it only here and not in dev_server.ts.

Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realized that other servers are supposed to work when building to disk (out/ directory) so it makes sense to support localhost:8080 on those.

We can remove the token from dev_server.ts (though it's not critical). If you do, update the comment below

standalone/index.html Outdated Show resolved Hide resolved
@dneto0 dneto0 enabled auto-merge (squash) September 6, 2024 22:48
@dneto0 dneto0 merged commit 6c236a3 into gpuweb:main Sep 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants