Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce default maxSubcasesInFlight instead of using batching #4006

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

kainino0x
Copy link
Collaborator

I forgot that we could adjust maxSubcasesInFlight to avoid problems with there being too many subcases in a case.

This reverts commit ec54937 as well as changes the default value for maxSubcasesInFlight.

Should help with OOMs seen on a bunch of tests due to trying to compile 500 pipelines simultaneously.
https://crbug.com/373485785

Issue: None


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

I forgot that we could adjust maxSubcasesInFlight to avoid problems with
there being too many subcases in a case.

This reverts commit ec54937 as well as
changes the default value for maxSubcasesInFlight.
@kainino0x kainino0x enabled auto-merge (squash) October 16, 2024 20:22
@kainino0x kainino0x merged commit ecefa0d into gpuweb:main Oct 16, 2024
1 check passed
@kainino0x kainino0x deleted the reduce-max-subcases branch October 16, 2024 21:04
teoxoy pushed a commit to mozilla/gpuweb-cts that referenced this pull request Oct 25, 2024
…4006)

I forgot that we could adjust maxSubcasesInFlight to avoid problems with
there being too many subcases in a case.

This reverts commit ec54937 as well as
changes the default value for maxSubcasesInFlight.
teoxoy pushed a commit to mozilla/gpuweb-cts that referenced this pull request Oct 25, 2024
…4006)

I forgot that we could adjust maxSubcasesInFlight to avoid problems with
there being too many subcases in a case.

This reverts commit ec54937 as well as
changes the default value for maxSubcasesInFlight.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants