Re-enable linear with comparisons. #4026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a little confusing but depth textures used for "sampling" are not filterable but used for "comparisons" they are. | | texture_?d<f32> with depth texture | texture_depth_?? | | ----------------------------- | ---------------------------------- | ---------------- | | sampler `'linear'` | bad | bad | | sampler_comparison `'linear'` | N/A | OK |
shrekshao
reviewed
Nov 1, 2024
| * * 'depth16unorm' -> false | ||
| * * 'rgba32float' -> true (you need to enable feature 'float32-filterable') | ||
| */ | ||
| export function isFilterableAsTextureF32(format: GPUTextureFormat) { |
There was a problem hiding this comment.
Question: are r16float, rg16float, rgba16float filterable as TextureF32?
There was a problem hiding this comment.
yes, all normal color formats are filterable as textureF32 (r8unorm, r8snorm, rgba8norm, compressed formats, etc....). Effectively this is can you use the texture with texture_2d<f32>, texture_2d_array<f32>, texture_cube<f32>, etc...
There was a problem hiding this comment.
Oh for r16float and etc, their info.color?.type is float already.
greggman
added a commit
to greggman/cts
that referenced
this pull request
Nov 2, 2024
texture_depth_xxx can only be used with non-filtering samplers or comparison samples, not with filtering samplers. see table in gpuweb#4026
greggman
added a commit
to greggman/cts
that referenced
this pull request
Nov 2, 2024
texture_depth_xxx can only be used with non-filtering samplers or comparison samples, not with filtering samplers. see table in gpuweb#4026 Also enabled more depth tests
greggman
added a commit
to greggman/cts
that referenced
this pull request
Nov 4, 2024
texture_depth_xxx can only be used with non-filtering samplers or comparison samples, not with filtering samplers. see table in gpuweb#4026 Also enabled more depth tests
greggman
added a commit
that referenced
this pull request
Nov 4, 2024
texture_depth_xxx can only be used with non-filtering samplers or comparison samples, not with filtering samplers. see table in #4026 Also enabled more depth tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a little confusing but depth textures used for "sampling" are not filterable but used for "comparisons" they are.
'linear''linear'