Merge 3rd: Proc macro cleanup #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
force-pushed
the
proc-macro-cleanup
branch
7 times, most recently
from
d23dda3
to
7f03460
Compare
nyurik
force-pushed
the
proc-macro-cleanup
branch
from
7f03460
to
c5f8e9c
Compare
nyurik
force-pushed
the
proc-macro-cleanup
branch
from
c5f8e9c
to
24a7337
Compare
|
This is now part of https://github.com/gquintard/varnish-rs/tree/feature-macro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up to #54 and #85, and should only be merged after that one (looking at diff doesn't make sense unless you look at the latest commit only, not the whole PR):
VclErrorinstead ofBox<Error>-- more work will be needed here to make them even more optimalDefault<TVcl>,From<TVcl> for TRust, andIntoVCL<TVcl> for TRust. The last one is the only custom one, using workspace.Default,From, and other messy stuff