Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute <arg> with <buildArg> in Maven plugin doc. #551

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

olyagpl
Copy link
Member

@olyagpl olyagpl commented Dec 15, 2023

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 15, 2023
@olyagpl olyagpl requested review from d-kozak, dnestoro and melix and removed request for d-kozak and lazar-mitrovic December 15, 2023 15:01
@@ -133,7 +133,7 @@ Build Configuration]. It is also possible to customize the plugin within a
[source,xml]
----
<buildArgs>
<arg>--argument</arg>
<buildArg>--argument</buildArg>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it change too for specifying JVM arguments?
Currently we have:

<jvmArgs>
    <arg>argument1</arg>
    <arg>argument2</arg>
</jvmArgs>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it ever changed, maybe it's Maven accepting both? @alvarosanchez wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for tags mapped as collections (like buildArgs), the inner tags can use any name. The convention is to use the singular form of the plural tag name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both!

@@ -133,7 +133,7 @@ Build Configuration]. It is also possible to customize the plugin within a
[source,xml]
----
<buildArgs>
<arg>--argument</arg>
<buildArg>--argument</buildArg>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for tags mapped as collections (like buildArgs), the inner tags can use any name. The convention is to use the singular form of the plural tag name.

@fniephaus fniephaus added this to the 0.9.29 milestone Jan 22, 2024
@dnestoro dnestoro merged commit 8765753 into master Jan 23, 2024
1 check passed
@dnestoro dnestoro deleted the og/maven-plugin-config-syntax branch January 23, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants