Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website fixes for mobile #8857

Merged
merged 25 commits into from
Aug 6, 2024
Merged

Website fixes for mobile #8857

merged 25 commits into from
Aug 6, 2024

Conversation

aliabd
Copy link
Collaborator

@aliabd aliabd commented Jul 21, 2024

Makes a lot of changes to the website so it works better on mobile.

  • Better header, buttons spaced out and more clickable, grouped together nicely.
  • Better search overlay.
  • Fixes all the responsive issues in docs, guides and playground.
  • Replaces lite on mobile with embedded spaces until we fix/figure out lite on safari.
  • Adds a better secondary menu for docs.
  • Switches playground to be code / preview toggle (non-interactive code and embedded spaces).

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 21, 2024

🪼 branch checks and previews

Name Status URL
Spaces failed! Details
Website ready! Website preview
Storybook failed! Details
🦄 Changes detected! Details

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 21, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
website minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Website fixes for mobile

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@aliabd aliabd self-assigned this Jul 22, 2024
@aliabd aliabd marked this pull request as ready for review August 5, 2024 06:49
@aliabd aliabd requested review from pngwn and abidlabs August 5, 2024 06:49
Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I only have one suggestion (which could be tackled in a subsequent pr or this one): the same secondary sidebar that appears on the docs page and the playground, should also appear in the Guides to help you easily navigate to a desired guide

@aliabd
Copy link
Collaborator Author

aliabd commented Aug 6, 2024

Thanks @abidlabs, added it to guides as well.

Screenshot 2024-08-05 at 9 04 31 PM

@aliabd aliabd merged commit 6584aac into main Aug 6, 2024
15 checks passed
@aliabd aliabd deleted the aliabd/website-mobile-fixes branch August 6, 2024 04:20
freddyaboulton pushed a commit that referenced this pull request Aug 6, 2024
* better header for mobile

* add changeset

* nicer border

* style header

* better search overlay

* responsive changes

* more mobile responsiveness

* docs and guides mobile responsive

* formatting

* fix get started button

* fix header

* test without lite

* formatting

* secondary menu docs

* fix type overflow in paramtable

* playground header

* playground on mobile

* small changes

* formatting

* formatting

---------

Co-authored-by: gradio-pr-bot <[email protected]>
freddyaboulton added a commit that referenced this pull request Aug 6, 2024
* Add code

* file_explorer test

* dont use fastapi

* Add code

* Update requirements.txt

* Ci security tweaks (#9010)

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* Ci security tweaks (#9012)

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* :[

* add cursor styling (#9003)

* Add min/max-imize button to gr.Image and gr.Gallery (#8964)

* add max/min-imize and zoom in and out to image preview

* add full screen icon to gallery

* add stories

* add changeset

* use native full screen api

* remove zoom in/out

* add changeset

* tweaks

* remove zoom prop

* fix ui test

* add annotated image btns

* add changeset

* format

* ruff format

* fix test

* remove

* tweak

* fix test

* format

* amend bool check

---------

Co-authored-by: gradio-pr-bot <[email protected]>
Co-authored-by: pngwn <[email protected]>

* Ci security tweaks (#9014)

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* asd

* :[

* asd

* asd (#9015)

* Ci security tweaks take seventy three (#9016)

* asd

* asd

* asd

* Ci security tweaks take seventy three (#9017)

* asd

* asd

* asd

* asd

* Ci security tweaks take seventy three (#9018)

* asd

* asd

* asd

* asd

* adsa

* asd

* Ci security tweaks take seventy three (#9019)

* asd

* asd

* asd

* asd

* adsa

* asd

* asd

* Website fixes for mobile  (#8857)

* better header for mobile

* add changeset

* nicer border

* style header

* better search overlay

* responsive changes

* more mobile responsiveness

* docs and guides mobile responsive

* formatting

* fix get started button

* fix header

* test without lite

* formatting

* secondary menu docs

* fix type overflow in paramtable

* playground header

* playground on mobile

* small changes

* formatting

* formatting

---------

Co-authored-by: gradio-pr-bot <[email protected]>

* Ci security tweaks take seventy three (#9025)

* asd

* asd

* asd

* asd

* adsa

* asd

* asd

* asd

* Ci security tweaks take seventy three (#9026)

* asd

* asd

* asd

* asd

* adsa

* asd

* asd

* asd

* fix

* asd (#9027)

* fix (#9028)

* Ci statuses (#9030)

* fix

* asd

* Update tests

* add changeset

* Add code

* add changeset

* Comments

---------

Co-authored-by: pngwn <[email protected]>
Co-authored-by: Hannah <[email protected]>
Co-authored-by: gradio-pr-bot <[email protected]>
Co-authored-by: Ali Abdalla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants