-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use HTTP Livestreaming for audio/video streaming out #8906
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/bed454c3d22cfacedc047eb3b0ba987b485ac3fd/gradio-4.40.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@bed454c3d22cfacedc047eb3b0ba987b485ac3fd#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-builds.s3.amazonaws.com/bed454c3d22cfacedc047eb3b0ba987b485ac3fd/gradio-client-1.4.0.tgz |
@@ -238,6 +238,30 @@ def show(n): | |||
return demo | |||
|
|||
|
|||
@pytest.fixture |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This got deleted somewhere along the line
Hey @freddyaboulton, thanks for taking care of this PR! Just a quick question from my side, since I'm following this feature very closely. When testing the |
That issue should be fixed now @ylacombe . Will work on the remaining tweaks/guides now! |
Going to merge and will add a guide in a follow up pr. e2e tests are being funky s skipping for now since they pass locally. |
Thanks so much @freddyaboulton! Tested once more and the issue I found earlier is resolved. |
Using this bugfix tag,the first time I click the button, there will be no voice on the webUI, I need to click again. |
Description
Reworks our approach for streaming media to use http live streaming. This is widely supported across browsers, mobile devices and gives us the following benefits:
Additional changes:
.ts
file withh.264
codec. The strictness of the encoding is set by http live streaming. Theh.264
codec is pretty standard from what I read but I added the ability to convert.mp4
files into the expect file type for streaming to make a bit easier for developers.🎯 PRs Should Target Issues
Closes #8185
Closes #6570
Closes: #5187
Closes #8177
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh