Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise WasmUnsupportedError for ffmpeg usage on Lite #9130

Merged
merged 9 commits into from
Aug 20, 2024

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented Aug 16, 2024

FFMpeg should be supported finally, but at this moment we set errors for easy debugging.

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Aug 16, 2024

🪼 branch checks and previews

Name Status URL
Website building...
🦄 Changes detected! Details

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Aug 16, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Raise WasmUnsupportedError for ffmpeg usage on Lite

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@whitphx whitphx added the v: patch A change that requires a patch release label Aug 16, 2024
Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whitphx
Copy link
Member Author

whitphx commented Aug 17, 2024

@freddyaboulton Correct! Thank you, I added it.

@@ -310,6 +310,10 @@ def postprocess(

@staticmethod
def _convert_to_adts(data: bytes):
if wasm_utils.IS_WASM:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also raise if needs_conversion is True in preprocess. I am pretty sure that pydub is using ffmpeg under the hood in that case.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @whitphx !

@whitphx whitphx merged commit 864cd0f into 5.0-dev Aug 20, 2024
20 checks passed
@whitphx whitphx deleted the ffmpeg-error-on-lite-5.0 branch August 20, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants