-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise WasmUnsupportedError for ffmpeg usage on Lite #9130
Conversation
🪼 branch checks and previews
|
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the audio component uses ffmpeg under the hood in save_audio_to_cache
functions. Playground link:
@freddyaboulton Correct! Thank you, I added it. |
@@ -310,6 +310,10 @@ def postprocess( | |||
|
|||
@staticmethod | |||
def _convert_to_adts(data: bytes): | |||
if wasm_utils.IS_WASM: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also raise if needs_conversion
is True
in preprocess
. I am pretty sure that pydub
is using ffmpeg under the hood in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @whitphx !
FFMpeg should be supported finally, but at this moment we set errors for easy debugging.