-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign gr.Button()
#9167
Redesign gr.Button()
#9167
Conversation
*add origin theme class with old button styling
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/4c04dc1310df8d29a243d299e52b776594d56e10/gradio-4.42.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@4c04dc1310df8d29a243d299e52b776594d56e10#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/4c04dc1310df8d29a243d299e52b776594d56e10/gradio-client-1.5.1.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
*style tweaks
i like it, burnished orange |
Huge fan of the changes @hannahblair! Everything looks good except that the stop button with light mode looks very faded out. I'd suggest darken the red & using a white font: similar to the primary button: |
@abidlabs you're right. I didn't want to stray too far from our current cancel buttons shade originally but it just looks much better dark. wdyt of this red? |
Looks perfect! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, tested the buttons again and they look great in both dark mode and light mode!
Description
Some notes/highlights:
translateY
by 0.5px on hover. You could argue it couldtranslateY
by -0.5px but I noticed in a demo that the button can get slightly cut off when moving down.Also adds an Origin theme which retains all the old styling.
Demo
Closes: #8789
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh