Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve button consistency across light/dark mode #9236

Merged
merged 2 commits into from
Sep 1, 2024
Merged

Conversation

hannahblair
Copy link
Collaborator

Description

The button border settings were feeling inconsistent in light and dark mode, with no border in light but a border in dark mode, and a hover border being lighter than the default fill in dark mode and darker in light mode. tl;dr this makes button borders better

Closes: #(issue)

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Sep 1, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/ddb5a9e698ebe40a47a96513876aa1e37593a7c4/gradio-4.42.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ddb5a9e698ebe40a47a96513876aa1e37593a7c4#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/ddb5a9e698ebe40a47a96513876aa1e37593a7c4/gradio-client-1.5.1.tgz

@hannahblair hannahblair changed the base branch from main to 5.0-dev September 1, 2024 14:17
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Sep 1, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Improve button consistency across light/dark mode

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@hannahblair
Copy link
Collaborator Author

merging as the failing tests are coming from 5.0-dev

@hannahblair hannahblair merged commit dd8e2e3 into 5.0-dev Sep 1, 2024
17 of 20 checks passed
@hannahblair hannahblair deleted the btn-tweaks branch September 1, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants