Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cached Examples for Streamed Media #9373

Merged
merged 14 commits into from
Sep 20, 2024
Merged

Conversation

freddyaboulton
Copy link
Collaborator

@freddyaboulton freddyaboulton commented Sep 17, 2024

Description

Broke cached examples for streaming video/audio in the 5.0 branch. This also fixes an issue with the download button for streamed video files where the downloaded video did not play correctly.

To test, run stream_video_out with cached examples

stream_video_cached_examples

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Sep 17, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/96992f6865a815ebb89ab6d918fcddadae60639e/gradio-4.44.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@96992f6865a815ebb89ab6d918fcddadae60639e#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/96992f6865a815ebb89ab6d918fcddadae60639e/gradio-client-1.6.0-beta.1.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/96992f6865a815ebb89ab6d918fcddadae60639e/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Sep 17, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/audio minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix Cached Examples for Streamed Media

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

abidlabs commented Sep 19, 2024

Beautiful work @freddyaboulton! The only issue I noticed, and not sure if its related to this PR, but the downloaded audio file (only the case of the cached example) does not have the '.wav' extension. Repro with:

import gradio as gr

def s(x):
    for i in range(5):
        yield x

demo = gr.Interface(s, gr.Audio(type="filepath"), gr.Audio(streaming=True), examples=["cantina.wav"], cache_examples=True)

demo.launch()

And could we add a unit test for combine_stream? Otherwise, lgtm!

@freddyaboulton
Copy link
Collaborator Author

The extension issue has been fixed @abidlabs !

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid, lgtm!

@abidlabs
Copy link
Member

Merging for the beta release!

@abidlabs abidlabs merged commit 6443062 into 5.0-dev Sep 20, 2024
20 of 21 checks passed
@abidlabs abidlabs deleted the fix-video-stream-download branch September 20, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants