Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <Render> moving {target} after {...node.props} because node.props… #9422

Closed
wants to merge 2 commits into from

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented Sep 24, 2024

… can have the target field and the {target} should be prioritized over node.props.target

Description

Please include a concise summary, in clear English, of the changes in this pull request. If it closes an issue, please mention it here.

Closes: #(issue)

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

… can have the target field and the {target} should be prioritized over node.props.target
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Sep 24, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/9abf8459c34cba086ba5aa90df32d61f6b41e96c/gradio-4.44.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@9abf8459c34cba086ba5aa90df32d61f6b41e96c#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/9abf8459c34cba086ba5aa90df32d61f6b41e96c/gradio-client-1.6.0-beta.3.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/9abf8459c34cba086ba5aa90df32d61f6b41e96c/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Sep 24, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/core minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix moving {target} after {...node.props} because node.props…

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@whitphx
Copy link
Member Author

whitphx commented Sep 24, 2024

Problem mentioned in #9339 (comment).

Now found that node.props can have target prop then it overrides the proper target prop passed to the component.
The current ver. of this PR workarounds it.

Will keep investigating why target is set to node.props.

@whitphx
Copy link
Member Author

whitphx commented Sep 24, 2024

client.resolve_config returns the config object and config.components[].props already has the target field.
Maybe devtool displayed the object with a newer state after mutation. Anyway such mutation occurs somewhere.

@whitphx
Copy link
Member Author

whitphx commented Oct 1, 2024

The problem was fixed by #9464

@whitphx whitphx closed this Oct 1, 2024
@whitphx whitphx deleted the fix-plot-target branch October 1, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants