Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lite worker refactoring #9424

Merged
merged 8 commits into from
Nov 2, 2024
Merged

Lite worker refactoring #9424

merged 8 commits into from
Nov 2, 2024

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented Sep 24, 2024

Description

Small refactorings on Lite. Not high priority. Plz review this when you have time.

@whitphx whitphx changed the base branch from main to 5.0-dev September 24, 2024 07:37
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Sep 24, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/ef95698f61ea6a4f62a65585c9a3a6c4c607e925/gradio-5.4.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ef95698f61ea6a4f62a65585c9a3a6c4c607e925#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/ef95698f61ea6a4f62a65585c9a3a6c4c607e925/gradio-client-1.7.1.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/ef95698f61ea6a4f62a65585c9a3a6c4c607e925/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Sep 24, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/lite patch
@gradio/wasm patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Lite worker refactoring

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Base automatically changed from 5.0-dev to main October 9, 2024 05:17
@whitphx whitphx added the v: patch A change that requires a patch release label Oct 10, 2024
@whitphx whitphx marked this pull request as ready for review October 11, 2024 04:36
Copy link
Collaborator

@aliabd aliabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @whitphx, thanks!

@aliabd
Copy link
Collaborator

aliabd commented Nov 2, 2024

not sure why lite unit test is failing

@whitphx
Copy link
Member Author

whitphx commented Nov 2, 2024

Maybe the old commits were the problem? Merging the current main solved it.

Now different unit tests are failing. Will fix them.

@whitphx
Copy link
Member Author

whitphx commented Nov 2, 2024

Found that the requestAnimationFrame trick is still needed because the timing of connectedCallback called may not be specified in the spec and we still need to care the case where the callback is called before parsing the child elements.

@whitphx whitphx merged commit a1582a6 into main Nov 2, 2024
23 of 24 checks passed
@whitphx whitphx deleted the lite-worker-refactoring branch November 2, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants