Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checkbox and radio borders #9429

Open
wants to merge 4 commits into
base: 5.0-dev
Choose a base branch
from
Open

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Sep 24, 2024

Description

Removes the checkbox and radio borders. Amends the new hover effect slightly to accommodate this.

new base
Screenshot 2024-09-24 at 18 32 15 Screenshot 2024-09-24 at 18 32 36

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Sep 24, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/77f0a340839cd2541df381a5846e24db37eead49/gradio-4.44.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@77f0a340839cd2541df381a5846e24db37eead49#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/77f0a340839cd2541df381a5846e24db37eead49/gradio-client-1.6.0-beta.3.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/77f0a340839cd2541df381a5846e24db37eead49/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Sep 24, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/checkboxgroup minor
@gradio/radio minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Remove checkbox and radio borders

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

abidlabs commented Sep 24, 2024

Hmm I prefer the borders tbh, looks too bare without them. Perhaps a single border around all of the choices would look good?

@aliabid94
Copy link
Collaborator

Can we also do this through theme variables rather than removing the variables entirely? So that some themes can preserve them and others can remove them.

@pngwn
Copy link
Member

pngwn commented Sep 27, 2024

Adding this comment I made from slack.

TLDR: I don't think the borders are the real problem, even ignoring this PR there are other issues with things looking too bare, mainly because if the removal of the separators with no other adjustments.


Chatbot with radios

image

blocks_essay demo

image

kitchen sink
image

Observations:

  • chatbot looks absurd but it always did so that isn't a big deal.
  • blocks_essay looks great
  • kitchen sink looks naked (only way i can describe it)

Possible solutions:

  • So the reason i think the chatbot looks silly is cos what we should try to do is balance the row + align the radio button.
  • I think the blocks essay might need more padding margin above
  • Not sure about kitchen sink, the checkboxes actually look okay but dno about the radios, they seem more problematic

I think radios might need more padding between them too actually, just a touch.

Yeah they do, there can't be the same space between the label text + the previous radio or the relationship isn't clear, checkboxes don't seem to have that issue

hmmm, i know we removed the separator because it was noisy but i feel the labels + margins aren't pulling their weight in separating things out

I think the label text needs to be more prominent and maybe we need more margin when stacking form elements like this. The ones with boxes look okay but slider etc look a bit lost + floaty

I feel like the label should be more prominent than the actual value text for example, those are like mini headings and are the only thing that really dictate the hierarchy now.

could also just be larger instead or darker, probably not both.

or maybe bolder but may look bad in dark mode unless we drop the weight by 100

@abidlabs
Copy link
Member

abidlabs commented Oct 1, 2024

tbh I prefer the borders in all of three demos above

@pngwn
Copy link
Member

pngwn commented Oct 1, 2024

Depends what they are there for, in a larger form i think they look really noisy. In small doses they look okay (but i don't think they look great).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants