-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix package.json exports
of @gradio/preview
#9468
Conversation
exports
of @gradio/preview
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/d93a1968b8eb3ccc9a9b4bc1ef53ef8a0ef4c25a/gradio-4.44.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@d93a1968b8eb3ccc9a9b4bc1ef53ef8a0ef4c25a#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/d93a1968b8eb3ccc9a9b4bc1ef53ef8a0ef4c25a/gradio-client-1.6.0-beta.3.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/d93a1968b8eb3ccc9a9b4bc1ef53ef8a0ef4c25a/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, nice catch!
Thanks for fixing this @Col0ring!
Updated the base branch to be |
Actually this is one case where we should patch |
Description
The new version of
@gradio/preview
added theexports
field inpackage.json
, which caused the file path exported by themain
field to be overwritten. It‘s necessary to add the corresponding path in theexports
field.Closes: #9445
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh