Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package.json exports of @gradio/preview #9468

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

Col0ring
Copy link
Contributor

Description

The new version of @gradio/preview added the exports field in package.json, which caused the file path exported by the main field to be overwritten. It‘s necessary to add the corresponding path in the exports field.

Closes: #9445

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@Col0ring Col0ring changed the title Fix package.json exports of @gradio/preview Fix package.json exports of @gradio/preview Sep 29, 2024
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Sep 29, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/d93a1968b8eb3ccc9a9b4bc1ef53ef8a0ef4c25a/gradio-4.44.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@d93a1968b8eb3ccc9a9b4bc1ef53ef8a0ef4c25a#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/d93a1968b8eb3ccc9a9b4bc1ef53ef8a0ef4c25a/gradio-client-1.6.0-beta.3.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/d93a1968b8eb3ccc9a9b4bc1ef53ef8a0ef4c25a/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Sep 29, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/preview patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix package.json exports of @gradio/preview

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice catch!

Thanks for fixing this @Col0ring!

@abidlabs abidlabs changed the base branch from main to 5.0-dev September 30, 2024 14:14
@abidlabs
Copy link
Member

Updated the base branch to be 5.0-dev

@abidlabs abidlabs merged commit 36d6636 into gradio-app:5.0-dev Sep 30, 2024
19 of 22 checks passed
@abidlabs
Copy link
Member

Actually this is one case where we should patch main as well. I'll go ahead and do that now.

@abidlabs abidlabs mentioned this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Component : cc gradio build Error
4 participants