Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End term project page update #65

Merged
merged 3 commits into from
Aug 24, 2024

Conversation

Tanish-Ranjan
Copy link
Contributor

No description provided.


**Supporting Diagrams:**

<div class="img_container">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be really required, a normal Markdown image inclusion would be enough

@@ -107,8 +150,11 @@ Throughout the program I have collaborated with all of my mentors and gained inv

My work on this project, significantly expanded my skill set, encompassing JSON-RPC, Language Server Protocol, Build Server Protocol, Gradle API, Gradle Tooling API, testing methodologies and merging techniques with git. I successfully applied these learnings to produce the mentioned outcomes.

If anyone is interested to continue the work and bring further support for Android projects in the [GradleBuildServer](https://github.com/microsoft/build-server-for-gradle) then you can get started [here](https://github.com/microsoft/build-server-for-gradle/labels/android).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If anyone is interested to continue the work and bring further support for Android projects in the [GradleBuildServer](https://github.com/microsoft/build-server-for-gradle) then you can get started [here](https://github.com/microsoft/build-server-for-gradle/labels/android).
If anyone is interested to continue the work and bring further support for Android projects in [Gradle Build Server](https://github.com/microsoft/build-server-for-gradle) then you can get started [here](https://github.com/microsoft/build-server-for-gradle/labels/android).

@@ -3,13 +3,13 @@
This project aims to enhance [Gradle Build Server](https://github.com/microsoft/build-server-for-gradle) project from Microsoft by integrating powerful Android Studio features. Bridging the build process gap between [Android Studio](https://developer.android.com/studio) and [Gradle Build Server](https://github.com/microsoft/build-server-for-gradle), will significantly improve the development experience for many Android developers using Text Editors/IDEs which utilize the [Build Server Protocol (BSP)](https://build-server-protocol.github.io).

## Status
Passed mid-term evaluation with successful completion of composite build support, Java Home handling under review and android support in progress.
Passed mid-term evaluation with successful completion of composite build support, Java Home handling under review and android support in review.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Passed mid-term evaluation with successful completion of composite build support, Java Home handling under review and android support in review.
Passed mid-term evaluation with successful completion of composite build support, `JAVA_HOME` handling under review and Android support in review.


**Limitations:**

- The current implementation only allows for recognition of Java sources.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good place to reference tickets as a follow-up

@@ -107,8 +150,11 @@ Throughout the program I have collaborated with all of my mentors and gained inv

My work on this project, significantly expanded my skill set, encompassing JSON-RPC, Language Server Protocol, Build Server Protocol, Gradle API, Gradle Tooling API, testing methodologies and merging techniques with git. I successfully applied these learnings to produce the mentioned outcomes.

If anyone is interested to continue the work and bring further support for Android projects in the [GradleBuildServer](https://github.com/microsoft/build-server-for-gradle) then you can get started [here](https://github.com/microsoft/build-server-for-gradle/labels/android).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also make sure to reference the key issues, the linked list will be a moving target

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will linking this comment work or should I list all the issues individually?

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Aug 24, 2024 via email

@Tanish-Ranjan
Copy link
Contributor Author

@oleg-nenashev Referencing the comment should be fine.

Okay. I have referenced the comment and also listed the issues

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's land it. Thanks for updating the overview. I will take another look later to see what else could be added, but overall it looks pretty good

@oleg-nenashev oleg-nenashev merged commit f2073ec into gradle:main Aug 24, 2024
1 check passed
@Tanish-Ranjan Tanish-Ranjan deleted the refactor/update-project-page branch August 24, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants