-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project page update for GSoC after final evaluation. #75
Project page update for GSoC after final evaluation. #75
Conversation
- There various kinds of projects that come under Android development such as Application, Library, Instant App, Dynamic Modules, Android Test, etc. I have added support for the most commonly used projects - Application and Library but the current implementation may require further enhancements to support other kinds of projects. ([Issue #182](https://github.com/microsoft/build-server-for-gradle/issues/182)) | ||
- My implementation takes into account any user defined build variants and the default build variants - debug and release except the default test variants - test and androidTest. ([Issue #183](https://github.com/microsoft/build-server-for-gradle/issues/183)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oleg-nenashev I have a PR for this issue in GBS. Should that be mentioned here? The mentioned issue does link to the PR though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, though it'd be nice to mention that it was after the project ended
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -90,7 +90,7 @@ As the popularity of Android development grows, the need for efficient build aut | |||
|
|||
### Android Java Project Support | |||
|
|||
**Status:** Complete (Under Review) :yellow_circle: | |||
**Status:** Complete (Merged) :green_circle: | |||
|
|||
**Pull Request:** [#173](https://github.com/microsoft/build-server-for-gradle/pull/173) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To provide the android support in Gradle for Java vscode extension I also added a PR in vscode-gradle repository. Should that be mentioned here? It wasn't part of the original goal though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense, though I would mention explicitly that it was merged after the Project end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -160,6 +161,8 @@ Within the Gradle Build Server I have added unit tests and integration tests to | |||
</div> | |||
</div> | |||
|
|||
[//]: # (TODO: Attach end term demo video once published) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I still haven't finished it yet. Will do on the weekend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries. I just left a todo to remind myself later.
No description provided.