Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix device issue in metric calculation #106

Merged
merged 5 commits into from
Oct 8, 2021
Merged

Conversation

aniketmaurya
Copy link
Contributor

@aniketmaurya aniketmaurya commented Oct 8, 2021

Changes

Fixes #105 #104

Type of change

  • 📚 Documentation Update
  • 🧪 Tests Cases
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔬 New feature (non-breaking change which adds functionality)
  • 🚨 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change?

@aniketmaurya aniketmaurya self-assigned this Oct 8, 2021
@aniketmaurya aniketmaurya modified the milestones: 0.0.6, 0.0.7 Oct 8, 2021
@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.50%. Comparing base (2b6d9df) to head (1c46403).
Report is 76 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   93.51%   93.50%   -0.01%     
==========================================
  Files          48       48              
  Lines        1341     1340       -1     
==========================================
- Hits         1254     1253       -1     
  Misses         87       87              
Flag Coverage Δ
unittests 93.50% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aniketmaurya aniketmaurya merged commit 27b2044 into main Oct 8, 2021
@aniketmaurya aniketmaurya deleted the bugfix/device_error branch October 8, 2021 13:36
@aniketmaurya aniketmaurya added bug / fix Something isn't working or a Bug Fix and removed bugfix labels Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working or a Bug Fix example test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

device mismatch error in calculating metrics
1 participant