Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥Data refactor #113

Merged
merged 6 commits into from
Oct 13, 2021
Merged

🔥Data refactor #113

merged 6 commits into from
Oct 13, 2021

Conversation

aniketmaurya
Copy link
Contributor

@aniketmaurya aniketmaurya commented Oct 13, 2021

Changes

Fixes #99

Type of change

  • 📚 Documentation Update
  • 🧪 Tests Cases
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔬 New feature (non-breaking change which adds functionality)
  • 🚨 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change?

@github-actions github-actions bot added the test label Oct 13, 2021
@aniketmaurya aniketmaurya added API design enhancement New feature or request labels Oct 13, 2021
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #113 (7f73e42) into main (72e06c7) will decrease coverage by 0.17%.
The diff coverage is 91.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   94.50%   94.32%   -0.18%     
==========================================
  Files          51       52       +1     
  Lines        1492     1534      +42     
==========================================
+ Hits         1410     1447      +37     
- Misses         82       87       +5     
Flag Coverage Δ
unittests 94.32% <91.96%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gradsflow/models/tracker.py 92.85% <ø> (-0.17%) ⬇️
gradsflow/models/utils.py 91.30% <ø> (-0.70%) ⬇️
gradsflow/models/base.py 89.58% <66.66%> (+0.05%) ⬆️
gradsflow/callbacks/runner.py 92.30% <71.42%> (-3.15%) ⬇️
tests/callbacks/test_runner.py 92.85% <92.85%> (ø)
gradsflow/data/autodata.py 91.22% <93.87%> (+6.22%) ⬆️
gradsflow/callbacks/__init__.py 100.00% <100.00%> (ø)
gradsflow/callbacks/progress.py 96.07% <100.00%> (ø)
gradsflow/core/data.py 100.00% <100.00%> (+6.06%) ⬆️
gradsflow/models/model.py 95.86% <100.00%> (-1.62%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72e06c7...7f73e42. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aniketmaurya aniketmaurya enabled auto-merge (squash) October 13, 2021 09:38
@aniketmaurya aniketmaurya changed the title Data refactor 🔥Data refactor Oct 13, 2021
@aniketmaurya aniketmaurya merged commit 811fa66 into main Oct 13, 2021
@aniketmaurya aniketmaurya deleted the data_refactor branch October 13, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API design enhancement New feature or request test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support dataset & dataloader in AutoDataset
1 participant