Student API Fixes | SIS-36 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
agitrubard
commented
Nov 27, 2021
agitrubard
commented
- StudentController/getAllStudents Method Has Been Renamed
- StudentPersonalInfoService/saveStudentPersonalInfo Method Have Been Fixed Because This Method Mustn't Have Return Type
- Service Interface Methods Have Been Fixed
- StudentResponseConverter/convertList Method Has Been Renamed
- StudentResponseConverter/convert Method Has Been Renamed
- Converter Methods Have Been Moved to Under Constructor Method
- Annotation Has Been Deleted Because It's Unused
…ixed Because This Method Mustn't Have Return Type
agitrubard
added
pending test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.