Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update windows_exporter with latest #1631

Closed
mattdurham opened this issue Apr 20, 2022 · 6 comments · Fixed by #3603
Closed

Update windows_exporter with latest #1631

mattdurham opened this issue Apr 20, 2022 · 6 comments · Fixed by #3603
Assignees
@mattdurham
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. keepalive Never close from staleness outdated-dependency Depdency of the project that is out of date

Comments

@mattdurham
Copy link
Collaborator

Update windows_exporter with latest version of the community windows exporter
@mattdurham
Copy link
Collaborator Author

We use a forked version of the windows_exporter that is pretty different so merging is more involved.

@mattdurham mattdurham added keepalive Never close from staleness outdated-dependency Depdency of the project that is out of date queued labels Apr 27, 2022
@splitt3r
Copy link

This would be great 👍🏻 https://github.com/prometheus-community/windows_exporter/blob/master/docs/collector.scheduled_task.md seems to be missing here currently.

@mattdurham mattdurham self-assigned this May 19, 2022
@splitt3r splitt3r mentioned this issue Jul 24, 2022
Closed
@splitt3r splitt3r mentioned this issue Aug 21, 2022
Closed
@splitt3r
Copy link

Hey @mattdurham dont't want to bother you. Are there any plans to work on this in the near future? Also is it possible to merge the changes from Grafana upstream to make future updates easier?

@mattdurham
Copy link
Collaborator Author

It is currently at the back of the queue. I have no idea when it will be resolved. As far as merging the upstream when we do this we can take a look to see how far they diverged and if upstream is willing to take the changes.

@splitt3r
Copy link

Ok. Thanks for the update.

@jkroepke
Copy link
Contributor

I will also look into this, since I'm also interested into a updated windows exporter dependency. But I agree we with mattdurham that upstream changes are requires that can take a well and no one knows if they want to accept them.

@jkroepke jkroepke mentioned this issue Apr 23, 2023
Merged
3 tasks
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mattdurham mattdurham

Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. keepalive Never close from staleness outdated-dependency Depdency of the project that is out of date
Projects
No open projects
Grafana Agent (Public)
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to upstream windows_exporter jkroepke/grafana-agent
4 participants
@rfratto @jkroepke @splitt3r @mattdurham