-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to upstream windows_exporter #3603
Conversation
221ce36
to
a2d0899
Compare
b6abe5c
to
ec6af39
Compare
Reviewing this and going to run it on my local VM to smoke test it a bit. |
Not your issue but can we fix the doc, |
ec6af39
to
1e91b23
Compare
@mattdurham I hope I address all you issues! |
I may tweak a few things here and there but this is solid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work, some small formatting things/deprecation notes but I will fix them post merge.
@jkroepke can you debug the windows_exporter, I noticed when debugging agent on windows and also windows_exporter directly I get a syscall error. Several others were able to recreate. Running without the debugger is fine. |
Seems to be a specific line in perflib.go |
And to close this out found the issue leoluk/perflib_exporter#42, if you check the error while running on RegKeyClose it returns invalid handle which for whatever reason crashes when debugger is attached. |
https://github.com/grafana/agent/blob/main/docs/sources/static/configuration/integrations/windows-exporter-config.md should be updated to cover the changes mentioned in the changelog. |
* Integrate new windows_exporter * go mod tidy * Add Black and whitelist to initial config * fix ordering * fix docs
* Integrate new windows_exporter * go mod tidy * Add Black and whitelist to initial config * fix ordering * fix docs
PR Description
This PR removes the outdated internal grafana/windows_exporter fork.
This PR is still in draft, since various upstream PR needs to be solved first. This PR based on personal forks of windows_exporter which are planned to be merged upstreamed. After that, the PR is ready to review.
I'm creating the PR right now to indicate that some is working on the windows_exporter.
It introduce a breaking change from prometheus-community/windows_exporter#1170 (not sure how to handle this). If Grafana Agent follows SemVer, the breaking change is fine.
Test on a windows 10 system with following config:
Prometheus UI:
Which issue(s) this PR fixes
windows_exporter
merged upstream and removereplace
in go.mod #3420Notes to the Reviewer
PR Checklist