-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync defaults in otelcol.receiver.opencensus #6489
Comments
Consider that OpenCensus has merged into OpenTelemetry and is encouraging people to migrate to the latter in addition to the OpenTelemetry folks's effort as well I wonder if we should continue with the component to conserve engineering powers 🤖 (my 2c ofc) |
This commit re-syncs `otelcol.receiver.opencensus` with the upstream defaults, namely changing the default listen port from 4317 to 55678. This is considered a breaking change; a section has been written in the upgrade guide notifying users to explicitly set the endpoint to the previous port to retain old behavior when upgrading. Closes grafana#6489.
This one makes me worried because we're so close to releasing 1.0, so if we're going to make breaking changes it really needs to be now. Even with encouraging people to migrate, it can sometimes take organizations a really long time to move off of old tooling, so in this case I think it's better to make sure we're aligned with upstream going into 1.0. I spent a few minutes to fix this and opened #6682 so we can move on :) |
This commit re-syncs `otelcol.receiver.opencensus` with the upstream defaults, namely changing the default listen port from 4317 to 55678. This is considered a breaking change; a section has been written in the upgrade guide notifying users to explicitly set the endpoint to the previous port to retain old behavior when upgrading. Closes #6489.
This file notes that our defaults for otelcol.receiver.opencensus have desynced with upstream (or in this case, I'm not sure it was ever correct).
agent/converter/internal/otelcolconvert/testdata/opencensus.yaml
Lines 6 to 8 in c58709a
Changing a listening port like this would be a breaking change, but given how 4317 is used by another receiver by default, I think it's justifiable in this case; we should change our default for otelcol.receiver.opencensus to align with the upstream opencensusreceiver component.
The text was updated successfully, but these errors were encountered: