-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft up a way to translate otel loki receiver to flow #6782
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: erikbaranowski <[email protected]>
@@ -61,9 +61,15 @@ func getValueOverrideHook() builder.ValueOverrideHook { | |||
return ConvertTargets{ | |||
Targets: value, | |||
} | |||
case flow_relabel.Rules: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Promtail converter code does not use the common utils for this so we need to add code here
} | ||
|
||
func toServer(cfg *lokireceiver.Protocols) server.Config { | ||
return server.Config{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots to figure out here with how to convert the server
HTTPServerReadTimeout: 0, | ||
HTTPServerWriteTimeout: 0, | ||
HTTPServerIdleTimeout: 0, | ||
GRPCListenAddress: "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otel supports GRPC for their receiver and while ours has them wired up as flow arguments it is not supported. I created a new issue to add this support here: https://github.com/grafana/agent/issues/6783
@@ -8,7 +8,7 @@ import ( | |||
"github.com/grafana/agent/internal/component/common/loki" | |||
"github.com/grafana/agent/internal/converter/diag" | |||
"github.com/grafana/agent/internal/converter/internal/common" | |||
"github.com/grafana/agent/internal/converter/internal/promtailconvert/internal/build" | |||
"github.com/grafana/agent/internal/converter/internal/promtailconvert/build" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These files all had to move in order to let the otelcol converter make use of them
This PR has not had any activity in the past 30 days, so the |
PR Description
Which issue(s) this PR fixes
Closes grafana/alloy#242
Notes to the Reviewer
PR Checklist