templates: add (org-aware) AlertingListURL to ExternalData and fix Slack receiver #241
+126
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the receivers use the /alerting/list for grouping alerts when their generator URLs aren't the same. However these alerting list URLs are not "org-aware". Instead of passing an orgId to every receiver constructor, we can enrich the template (extended) data with a URL that has the ?orgID=N in case it exists in the common annotations, to be reused by any receiver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the receivers use the /alerting/list for grouping alerts when their generator URLs aren't the same.
However these alerting list URLs are not "org-aware".
Instead of passing an orgId to every receiver constructor, we can enrich the template (extended) data with a URL that has the
?orgID=Nin case it exists in the common annotations, to be reused by any receiver.I've also updated the Slack receiver as an example, since it fixes #69248. If you approve of the approach, I can update the other receivers.