Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use original fork of kafka_exporter #464

Closed
Tracked by #466
marctc opened this issue Apr 3, 2023 · 6 comments · Fixed by grafana/agent#6778 or #562
Closed
Tracked by #466

Use original fork of kafka_exporter #464

marctc opened this issue Apr 3, 2023 · 6 comments · Fixed by grafana/agent#6778 or #562
Assignees
Labels
frozen-due-to-age outdated-dependency Related to an outdated dependency.

Comments

@marctc
Copy link
Contributor

marctc commented Apr 3, 2023

For some reason, we are using a fork of kafka exporter that is not the original exporter. This cause issues like #502 where we are lagging behind of new version of kafka exporter.

@marctc
Copy link
Contributor Author

marctc commented Apr 3, 2023

cc @gaantunes as you where the original author of the integration

@hainenber
Copy link
Contributor

I tried going back to original version and realize the reason of using forked one is due to the original isn't usable as library 😞

image

I think, we may want to fork another version from danielqsj/kafka_exporter (original) and re-add commits from davidmparrott/kafka_exporter (currently used). In that way, we can sync upstream updates and still retain the ability to use it as library.

Wdyt?

@max107
Copy link

max107 commented Jan 15, 2024

fork is really required? maybe suggest danielqsj/kafka_exporter move codebase as a library?

@gaantunes
Copy link
Contributor

In addition to moving the exporter to a lib, the fork we use also adds lag consumption time estimation, which is an important metric for us.

The mantainer said he is open to these changes, and I started working on it, but had to drop due to conflicting priorities. Won't be able to return to it in the foresseable future, but can help with context and reviews if someone is able to pick up the work.

@ptodev ptodev self-assigned this Mar 4, 2024
@ptodev ptodev assigned wildum and unassigned ptodev Mar 21, 2024
@rfratto rfratto added the outdated-dependency Related to an outdated dependency. label Apr 9, 2024
@rfratto
Copy link
Member

rfratto commented Apr 11, 2024

Hi there 👋

On April 9, 2024, Grafana Labs announced Grafana Alloy, the spirital successor to Grafana Agent and the final form of Grafana Agent flow mode. As a result, Grafana Agent has been deprecated and will only be receiving bug and security fixes until its end-of-life around November 1, 2025.

To make things easier for maintainers, we're in the process of migrating all issues tagged variant/flow to the Grafana Alloy repository to have a single home for tracking issues. This issue is likely something we'll want to address in both Grafana Alloy and Grafana Agent, so just because it's being moved doesn't mean we won't address the issue in Grafana Agent :)

@rfratto rfratto transferred this issue from grafana/agent Apr 11, 2024
@rfratto
Copy link
Member

rfratto commented Apr 12, 2024

Reopening, not fixed in Alloy

@rfratto rfratto reopened this Apr 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age outdated-dependency Related to an outdated dependency.
Projects
No open projects
7 participants