Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop usage of custom Prometheus exporters forks #466

Open
10 of 11 tasks
marctc opened this issue Apr 3, 2023 · 1 comment
Open
10 of 11 tasks

Drop usage of custom Prometheus exporters forks #466

marctc opened this issue Apr 3, 2023 · 1 comment
Labels
outdated-dependency Related to an outdated dependency.

Comments

@marctc
Copy link
Contributor

marctc commented Apr 3, 2023

Currently we are using replace directive in go.mod for a specific subset of Prometheus exporters.
These forks were initially created to make them work with the Agent as some of the exporters need to be configure via command line flag (like windows exporter) or don't provide a way to initialize a collector from an external package.

The main problem is that the forks get outdated at some point, making harder to keep up to date (merge upstream dependencies is not always easier) and frequently unattended.

We should work with upstream exporters to port changes there (whenever is possible). These are the following exporters that need to be addressed:

Tasks

Related #548

@marctc marctc changed the title Remove exporter's forks Work with upstream prometheus exporter to get agent's changes merged Apr 3, 2023
@marctc marctc changed the title Work with upstream prometheus exporter to get agent's changes merged Work with upstream prometheus exporters to get agent's changes merged Apr 3, 2023
@marctc marctc changed the title Work with upstream prometheus exporters to get agent's changes merged Drop usage of custom Prometheu exporters forks Apr 6, 2023
@marctc marctc changed the title Drop usage of custom Prometheu exporters forks Drop usage of custom Prometheus exporters forks Apr 24, 2023
@rfratto rfratto added the outdated-dependency Related to an outdated dependency. label Apr 9, 2024
@rfratto
Copy link
Member

rfratto commented Apr 11, 2024

Hi there 👋

On April 9, 2024, Grafana Labs announced Grafana Alloy, the spirital successor to Grafana Agent and the final form of Grafana Agent flow mode. As a result, Grafana Agent has been deprecated and will only be receiving bug and security fixes until its end-of-life around November 1, 2025.

To make things easier for maintainers, we're in the process of migrating all issues tagged variant/flow to the Grafana Alloy repository to have a single home for tracking issues. This issue is likely something we'll want to address in both Grafana Alloy and Grafana Agent, so just because it's being moved doesn't mean we won't address the issue in Grafana Agent :)

@rfratto rfratto transferred this issue from grafana/agent Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outdated-dependency Related to an outdated dependency.
Projects
No open projects
Development

No branches or pull requests

2 participants