Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to enable streaming of chunks. #276

Merged
merged 1 commit into from
Mar 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
* [FEATURE] Added "Cortex / Slow queries" dashboard based on Loki logs. #271
* [ENHANCEMENT] Add `EtcdAllocatingTooMuchMemory` alert for monitoring etcd memory usage. #261
* [ENHANCEMENT] Sort legend descending in the CPU/memory panels. #271
* [ENHANCEMENT] Add config option to enable streaming of chunks in block-based ingesters. #276
* [BUGFIX] Fixed `CortexQuerierHighRefetchRate` alert. #268

## 1.7.0 / 2021-02-24
Expand Down
11 changes: 6 additions & 5 deletions cortex/config.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,9 @@
enable_pod_priorities: true,

alertmanager_enabled: false,

// Enables streaming of chunks from ingesters using blocks.
ingester_stream_chunks_when_using_blocks: true,
},

local configMap = $.core.v1.configMap,
Expand All @@ -441,11 +444,9 @@
configMap.new($._config.overrides_configmap) +
configMap.withData({
'overrides.yaml': $.util.manifestYaml(
{
overrides: $._config.overrides,
} + if std.length($._config.multi_kv_config) > 0 then {
multi_kv_config: $._config.multi_kv_config,
} else {}
{ overrides: $._config.overrides }
+ (if std.length($._config.multi_kv_config) > 0 then { multi_kv_config: $._config.multi_kv_config } else {})
+ (if $._config.ingester_stream_chunks_when_using_blocks then { ingester_stream_chunks_when_using_blocks: true } else {})
),
}),

Expand Down