Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchtool: avoid registering DNS metrics twice #188

Merged
merged 3 commits into from
Jun 5, 2021
Merged

benchtool: avoid registering DNS metrics twice #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ae1c0b
avoid registering metrics twice for DNS provider
Jun 2, 2021
71dfd0f
update CHANGELOG
Jun 3, 2021
78a0534
Update CHANGELOG.md
edma2 Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Order should be `CHANGE`, `FEATURE`, `ENHANCEMENT`, and `BUGFIX`

## unreleased/master

* [BUGFIX] Benchtool: avoid duplicate DNS metrics registration when enabling both query and write benchmarking. #188
* [ENHANCEMENT] Added the ability to set an explicit user when Cortex is behind basic auth. #187

## v0.10.1
Expand Down
2 changes: 1 addition & 1 deletion pkg/bench/query_runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ func newQueryRunner(id string, tenantName string, cfg QueryConfig, workload *que
clientPool: map[string]v1.API{},
dnsProvider: dns.NewProvider(
logger,
extprom.WrapRegistererWithPrefix("benchtool_", reg),
extprom.WrapRegistererWithPrefix("benchtool_query_", reg),
dns.GolangResolverType,
),

Expand Down
2 changes: 1 addition & 1 deletion pkg/bench/write_runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func NewWriteBenchmarkRunner(id string, tenantName string, cfg WriteBenchConfig,
workload: workload,
dnsProvider: dns.NewProvider(
logger,
extprom.WrapRegistererWithPrefix("benchtool_", reg),
extprom.WrapRegistererWithPrefix("benchtool_write_", reg),
dns.GolangResolverType,
),
clientPool: map[string]*writeClient{},
Expand Down