Pass grpc request headers to GrpcInflightMethodLimiter #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
approved these changes
Oct 6, 2023
|
I will convert this to draft, and merge only after |
pstibrany
force-pushed
the
pass-grpc-request-header-to-grpc-inflight-method-limiter
branch
from
c503ec1
to
0d739db
Compare
This was referenced Oct 9, 2023
Merged
pstibrany
force-pushed
the
pass-grpc-request-header-to-grpc-inflight-method-limiter
branch
from
5edb466
to
bf8067d
Compare
This version is now available, updating PR and merging it. |
pstibrany
deleted the
pass-grpc-request-header-to-grpc-inflight-method-limiter
branch
ying-jeanne
pushed a commit
that referenced
this pull request
Nov 2, 2023
* Pass grpc request header (metadata) to GrpcInflightMethodLimiter. * Use custom type as context key. * Update CHANGELOG.md * Update grpc-go to 1.59.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
After grpc/grpc-go#6652, we can now pass gRPC request headers to our
GrpcInflightMethodLimiter. This allows implementations to perform additional checks before allowing the request in (see #391 for what we have in mind: httpgrpc URL or message size).Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]