promtail: add support for extra args #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hello, thank you for your feature request. I will recommend some code changes to implement this feature. |
voidquark
reviewed
Aug 16, 2024
voidquark
reviewed
Aug 16, 2024
voidquark
reviewed
Aug 16, 2024
voidquark
reviewed
Aug 16, 2024
voidquark
reviewed
Aug 16, 2024
|
I tested the above suggestion, and it works as expected, allowing additional flags to be added. Here is an example: promtail_extra_flags:
- "-server.enable-runtime-reload"
- "-config.expand-env=true"Resulting systemd unit configuration: ExecStart=/usr/bin/promtail \
-server.enable-runtime-reload \
-config.expand-env=true \
-config.file /etc/promtail/config.yml |
harryfinbow
force-pushed
the
promtail-support-extra-args
branch
from
4bd7cf7
to
831dbf2
Compare
harryfinbow
force-pushed
the
promtail-support-extra-args
branch
from
831dbf2
to
2f29525
Compare
voidquark
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to set any additional Promtail arguments/flags, such as
-server.enable-runtime-reloadand-config.expand-env=true, outside of those configured as role variables.Adds the ability to pass additional arguments/flags to each call of the Promtail binary.