Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update actions to use node 20 #220

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Chore: Update actions to use node 20 #220

merged 1 commit into from
Jun 3, 2024

Conversation

ashharrison90
Copy link
Contributor

No description provided.

Copy link

@baldm0mma baldm0mma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any worries this dep update will create any unforeseen issues? 4 major versions seem like a big jump! 🤔

@ashharrison90
Copy link
Contributor Author

ashharrison90 commented May 31, 2024

Any worries this dep update will create any unforeseen issues? 4 major versions seem like a big jump! 🤔

naw not really 😅 couple of reasons:

  • node has a slightly weird versioning strategy where every even version is their stable new major version, so it's kinda only 2 major versions
  • node is pretty stable. this was the amount of changes needed for the whole of grafana/grafana to move to node 20: Chore: Update to node 20 grafana#76097. i would expect these actions to be even more likely to just work.

@ashharrison90 ashharrison90 merged commit 008c799 into main Jun 3, 2024
3 checks passed
@ashharrison90 ashharrison90 deleted the ash/node-20 branch June 3, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants