Replace all GraphQL calls with REST API calls #224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default GitHub Actions app token, `secrets.GITHUB_TOKEN`, cannot make GraphQL calls. Without this patch, the cherry-pick and PR opening succeeds but then a confusing error comment is posted back on the original PR like in https://github.com/grafana/pyroscope/actions/runs/10606280342/job/29396725224?pr=3526. Removing the GraphQL call means that this workflow doesn't require GitHub App creation for each repository that wants to use it. Signed-off-by: Jack Baldry <[email protected]>
jdbaldry
added a commit
to jdbaldry/pyroscope
that referenced
this pull request
Sep 12, 2024
For more information, refer to grafana/grafana-github-actions#224. Signed-off-by: Jack Baldry <[email protected]>
jdbaldry
added a commit
to jdbaldry/pyroscope
that referenced
this pull request
Sep 12, 2024
For more information, refer to grafana/grafana-github-actions#224. Signed-off-by: Jack Baldry <[email protected]>
aleks-p
pushed a commit
to grafana/pyroscope
that referenced
this pull request
Sep 12, 2024
…3551) For more information, refer to grafana/grafana-github-actions#224. Signed-off-by: Jack Baldry <[email protected]>
github-actions bot
pushed a commit
to grafana/pyroscope
that referenced
this pull request
Sep 12, 2024
…3551) For more information, refer to grafana/grafana-github-actions#224. Signed-off-by: Jack Baldry <[email protected]> (cherry picked from commit 6819c91)
|
This is not the problem. PATs can make GraphQL calls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default GitHub Actions app token,
secrets.GITHUB_TOKEN, cannot make GraphQL calls. Without this patch, the cherry-pick and PR opening succeeds but then a confusing error comment is posted back on the original PR like in https://github.com/grafana/pyroscope/actions/runs/10606280342/job/29396725224?pr=3526.Removing the GraphQL call means that this workflow doesn't require GitHub App creation for each repository that wants to use it.