Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Deployment Reconcile only runs at startup #1573

Closed
mikel-carcoba-klarrio opened this issue Jun 6, 2024 · 2 comments · Fixed by #1574
Closed

[Bug] Deployment Reconcile only runs at startup #1573

mikel-carcoba-klarrio opened this issue Jun 6, 2024 · 2 comments · Fixed by #1574
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mikel-carcoba-klarrio
Copy link

mikel-carcoba-klarrio commented Jun 6, 2024 •
edited
Loading

Describe the bug
The deployments are only reconciled at the beginning.
Version
v5.9.0

To Reproduce
Deleting a deployment manually. The operator is not going to recreate it

Expected behavior
Once a manual deletion happened the deployment should be recreated

Suspect component/Location where the bug might be occurring

grafana-operator/controllers/grafana_controller.go

Line 204 in 0c7cf92

func (r *GrafanaReconciler) SetupWithManager(mgr ctrl.Manager) error {

@mikel-carcoba-klarrio mikel-carcoba-klarrio added bug Something isn't working needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 6, 2024
@ak185158
Copy link

ak185158 commented Jun 6, 2024

Experiencing the same issue. Grafana deployment isn't recreated if instance is destroyed even though grafana manifest exists.

theSuess added a commit that referenced this issue Jun 7, 2024
@theSuess
fix: use controller reference instead of owner reference
70d0529 
This fixes #1573. Without the controller reference, the owner reference only
affects resource deletion.
@theSuess theSuess mentioned this issue Jun 7, 2024
Merged
@theSuess theSuess added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 7, 2024
@theSuess
Copy link
Member

theSuess commented Jun 7, 2024

Thanks for reporting this. It appears that the conditions for the owns directive got more rigid. #1574 should fix this

@theSuess theSuess changed the title [Bug] Deployment Reconcile only runs at starup [Bug] Deployment Reconcile only runs at startup Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use controller reference instead of owner reference grafana/grafana-operator
3 participants
@theSuess @ak185158 @mikel-carcoba-klarrio